Let the classes! macro handle potential trailing comma. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basro
reviewed
Dec 15, 2024
Comment on lines
+350
to
+353
| // Same, handling case with a trailing comma | ||
| ($($exp:expr),+,) => { | ||
| ::stylance::JoinClasses::join_classes([$($exp.into()),*].as_slice()) | ||
| }; |
There was a problem hiding this comment.
Instead of creating a new duplicated case it is possible to add an optional comma at the end of the one above this.
|
Small feedback: it would have been nicer if you had added tests for your changes as well. Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.