Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Take that #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Take that #64

wants to merge 1 commit into from

Conversation

christopherchiu
Copy link
Contributor

No description provided.

@sangsta
Copy link
Contributor

sangsta commented Oct 3, 2017

This doesn't currently work :(
It only shows the images in the small carousel stuff. Not the title image.

@christopherchiu
Copy link
Contributor Author

Weird. It worked for me locally. Let me check it.

@mattam
Copy link
Contributor

mattam commented Oct 4, 2017

When I try building, it gives me a bunch of xcode errors, trying to debug.

@mattam
Copy link
Contributor

mattam commented Oct 4, 2017

Build is working after updating my xcode. I can click on the banner image and then scroll sideways to see more images.

There will be merge conflicts though with this branch. @christopherchiu , could you rebase the changes based off the latest from master?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@christopherchiu @sangsta @mattam