Update to be able to run on 3.4 with frozen strings #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
npezza93
changed the title
npezza93
force-pushed
the
frozen-strings
branch
from
57827a6
to
5f9f70b
Compare
jeremy
reviewed
Oct 9, 2024
Sija
reviewed
Oct 9, 2024
Sija
reviewed
Oct 9, 2024
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
jeremy
requested changes
Oct 10, 2024
npezza93
commented
Oct 10, 2024
lib/kamal/commands/base.rb
Outdated
| @@ -11,7 +11,7 @@ def initialize(config) | |||
| end | |||
|
|
|||
| def run_over_ssh(*command, host:) | |||
| "ssh #{ssh_proxy_args} -t #{config.ssh.user}@#{host} -p #{config.ssh.port} '#{command.join(" ").gsub("'", "'\\\\''")}'".squish | |||
| "ssh#{ssh_proxy_args} -t #{config.ssh.user}@#{host} -p #{config.ssh.port} '#{command.join(" ").gsub("'", "'\\\\''")}'".squish | |||
There was a problem hiding this comment.
Hmm i thought i had tests passing with this. But i think with this new approach you can remove squish at the end
Sija
reviewed
Oct 10, 2024
jeremy
reviewed
Oct 10, 2024
Co-authored-by: Sijawusz Pur Rahnama <[email protected]>
jeremy
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.