Support spaces in git repository path #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidstosik
commented
Oct 7, 2024
|
|
||
| included do | ||
| delegate :clone_directory, :build_directory, to: :"config.builder" | ||
| end |
There was a problem hiding this comment.
This delegation becomes superfluous when we need to escape the values returned by clone_directory and build_directory, so I just removed it. Inlined config.builder.clone_directory.shellescape in the single location it's needed, and factorized config.builder.build_directory.shellescape in the escaped_build_directory method.
davidstosik
commented
Oct 7, 2024
| def build_directory | ||
| "#{Dir.tmpdir}/kamal-clones/app/kamal/" | ||
| end | ||
|
|
There was a problem hiding this comment.
I wondered what this was, and realized it has become unnecessary when tests still passed without it.
davidstosik
force-pushed
the
v2.1.1/path-space-fix
branch
from
0bb649d
to
f45c754
Compare
|
cc @djmb |
|
Thanks @davidstosik! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1036
I haven't written any tests for this though I'd be interested to try.