Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to kamal-proxy 0.8.0 #1064

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Update to kamal-proxy 0.8.0 #1064

merged 1 commit into from
Oct 8, 2024

Conversation

djmb
Copy link
Collaborator

@djmb djmb commented Oct 6, 2024

Proxy changes:

Custom TLS certificates not supported in Kamal itself yet. Buffering SSE responses and wildcard subdomains will work without any Kamal changes.

Proxy changes:
- Add option to use custom TLS certificates (#17)
- Don't buffer SSE responses (#36)
- Allow routing to wildcard subdomains (#45)

Custom TLS certificates not supported in Kamal itself yet. Buffering
SSE responses and wildcard subdomains will work without any Kamal
changes.
@karls
Copy link

karls commented Oct 7, 2024

I didn't want to create a new issue, so commenting in here. Am I correct that currently there is no way to specify the kamal-proxy version without a code change in Kamal itself?

@paganotoni
Copy link

paganotoni commented Oct 7, 2024

@karls I was about to ask the same question, you beat me to it :D. FWIW: I was looking in the CLI commands for a kamal proxy upgrade.

@tuladhar
Copy link
Contributor

tuladhar commented Oct 7, 2024

I didn't want to create a new issue, so commenting in here. Am I correct that currently there is no way to specify the kamal-proxy version without a code change in Kamal itself?

@karls That's correct, it's currently hardcoded in the code.

PROXY_MINIMUM_VERSION = "v0.7.0"

@tuladhar
Copy link
Contributor

tuladhar commented Oct 7, 2024

@karls I was about to ask the same question, you beat me to it :D. FWIW: I was looking in the CLI commands for a kamal proxy upgrade.

I discovered that you can upgrade the Kamal Proxy using the following command:

kamal proxy reboot

If it's running old version, and new version is available, then it will upgrade, e.g:

ERROR (RuntimeError): Exception while executing on host certsdiscount-app1: kamal-proxy version v0.6.0 is too old, please reboot to update to at least v0.7.0

@paganotoni
Copy link

thanks @tuladhar. I tried rebooting. however, it did not work.

@tuladhar
Copy link
Contributor

tuladhar commented Oct 7, 2024

thanks @tuladhar. I tried rebooting. however, it did not work.

Same here. I tried rebooting again, but it didn’t update beyond what’s hardcoded in the code.

@djmb
Copy link
Collaborator Author

djmb commented Oct 8, 2024

Yes right now the version is fixed entirely. But I think we'll allow updating to later versions, or running your own image if you want to fork kamal-proxy

@djmb djmb merged commit bbfcbfa into main Oct 8, 2024
8 checks passed
@djmb djmb deleted the kamal-proxy-0.8.0 branch October 8, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants