Allow multiple hosts per service #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TLS is enabled, the hostnames it uses always match the service's hosts. So there's no need to duplicate them. We can instead just have a flag to note whether TLS is enabled for the service.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to associate multiple hostnames with a single service. For example:
You can use a comma-delimited list in the
hostflag, and/or specify the flag multiple times.When a service has multiple hostnames, requests to any of those hostnames will route to the service. If the service also specifies
--tls, then all of the host names will be covered in the TLS certificates.Closes #14.