Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update promotional image #1013

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: update promotional image #1013

wants to merge 1 commit into from
+0 −0

Conversation

JFrankfurt
Copy link
Contributor

@JFrankfurt JFrankfurt commented Sep 23, 2024 •
edited
Loading

noticed this image is not really the most descriptive asset for the linked experience

Gardo supplied this alternative

@vercel Vercel
Copy link

vercel bot commented Sep 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 9:24pm
web-base-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 23, 2024 9:24pm

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Sep 23, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@JFrankfurt JFrankfurt self-assigned this Sep 23, 2024
@omkarb omkarb requested a review from a team September 24, 2024 14:52
@JFrankfurt
Copy link
Contributor Author

this is waiting on an updated image with the correct aspect ratio

@JFrankfurt JFrankfurt marked this pull request as draft October 7, 2024 20:27
@JFrankfurt
Copy link
Contributor Author

setting this to draft until I get a new asset included

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omkarb omkarb omkarb approved these changes

@brendan-defi brendan-defi brendan-defi approved these changes

@kirkas kirkas Awaiting requested review from kirkas

@zencephalon zencephalon Awaiting requested review from zencephalon

Assignees

@JFrankfurt JFrankfurt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JFrankfurt @cb-heimdall @omkarb @brendan-defi