Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Millisecond Blocktimes #10

Conversation

fahimahmedx
Copy link

@fahimahmedx fahimahmedx commented Jul 23, 2024

Todo

  • Implement a pseudo "millisecond" blocktime by taking seconds and scaling them up into milliseconds, and pass tests.
  • Update ExecutionPayload to have Milliseconds field, as implemented in my op-geth
  • Modify all usages of L2BlockRef.Time to use ExecutionPayload.Milliseconds
  • Modify all usages of functions like cfg.isEcotone() to take in ExecutionPayload.Milliseconds instead of ExecutionPayload.Seconds
  • Update PayloadAttributes to have Milliseconds field
  • Update the checks in AttributesMatchBlock() to check based on the Millisecond fields of ExecutionPayload and PayloadAttributes
  • Update SpanBatch to use Milliseconds
  • Update SingularBatch to use Milliseconds
  • Update MarshalSSZ() and UnmarshalSSZ() in op-service/eth/ssz.go to include Milliseconds, and include test cases in ssz_test.go
  • Modify PayloadInfo.Timestamp to use timeint.Milliseconds` datatype
  • Investigate how computePayloadId() in l2_engine_api.go needs to be modified to support Milliseconds field in PayloadInfo.

fahimahmedx and others added 30 commits July 15, 2024 18:41
…t for adding Milliseconds to PayloadAttributes struct
Copy link

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Aug 14, 2024
@github-actions github-actions bot closed this Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant