Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo
ExecutionPayload
to haveMilliseconds
field, as implemented in my op-gethL2BlockRef.Time
to useExecutionPayload.Milliseconds
cfg.isEcotone()
to take inExecutionPayload.Milliseconds
instead ofExecutionPayload.Seconds
PayloadAttributes
to haveMilliseconds
fieldAttributesMatchBlock()
to check based on theMillisecond
fields ofExecutionPayload
andPayloadAttributes
SpanBatch
to useMilliseconds
SingularBatch
to useMilliseconds
MarshalSSZ()
andUnmarshalSSZ()
inop-service/eth/ssz.go
to includeMilliseconds
, and include test cases inssz_test.go
PayloadInfo.Timestamp to use
timeint.Milliseconds` datatypecomputePayloadId()
inl2_engine_api.go
needs to be modified to supportMilliseconds
field inPayloadInfo
.