Update /paymentTxParams and /submitPaymentTx endpoints to work with Slice payloads #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amhedcb
reviewed
Oct 9, 2024
| import { http } from 'viem'; | ||
|
|
||
| // Create a Wagmi config, and get the relayed slice data | ||
| export const wagmiConfig = createConfig({ |
There was a problem hiding this comment.
Do we need more mappings? or does Slice only support 8453 right now?
Comment on lines
+11
to
+16
| let value = txMessage.rpcProxySubmissionParams.typedData.message.value; | ||
| if (txMessage.additionalPayload.cartParams && txMessage.additionalPayload.slicerId) { | ||
| // construct the cart using the slicekit to calculate the total amount | ||
| value = await getSliceCartUsdcPrice({ cartParams: txMessage.additionalPayload.cartParams, slicerId: txMessage.additionalPayload.slicerId }); | ||
| } | ||
|
|
There was a problem hiding this comment.
Let's move this logic to a formatSliceTxMessageReponse helper as well
| allProducts, | ||
| }); | ||
|
|
||
| console.log({ cart }); |
There was a problem hiding this comment.
Remember to remove the console logs after we're sure implementation is the correct one
Comment on lines
+46
to
+62
| if (additionalPayload) { | ||
| const { txHash } = await relayPayWithAuthorization({ | ||
| cartParams: additionalPayload.cartParams, | ||
| slicerId: additionalPayload.slicerId, | ||
| totalUsdcPrice: value, | ||
| buyer: from, | ||
| chainId, | ||
| signature, | ||
| authorizationParams: { | ||
| from, | ||
| nonce, | ||
| to, | ||
| validAfter, | ||
| validBefore, | ||
| value, | ||
| }, | ||
| }); |
There was a problem hiding this comment.
As discussed during Sync: Let's move this to a new endpoint called submitSlicePaymentTx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.