[sepolia] deploy revshare contracts to sepolia #119
Conversation
| BATCH_SENDER=0x6CDEbe940BC0F26850285cacA097C11c33103E47 | ||
| OUTPUT_PROPOSER_TARGET_BALANCE=200000000000000000000 | ||
| BATCH_SENDER_TARGET_BALANCE=1000000000000000000000 | ||
| BALANCE_TRACKER_ADMIN=0x608081689Fe46936fB2fBDF7552CbB1D80ad4822 |
There was a problem hiding this comment.
owner() in L1 ProxyAdmin https://sepolia.etherscan.io/address/0x0389E59Aa0a41E4A413Ae70f0008e76CAA34b1F3#readContract
There was a problem hiding this comment.
this is correct! but we do want to eventually change these admins to being the Gnosis safes we setup so would be ideal if we just set that to be the admin to avoid another owernship transfer later
| FEE_DISBURSER_DEPLOYER=<> | ||
| OPTIMISM_WALLET=<> | ||
| FEE_DISBURSEMENT_INTERVAL=604800 # 60 seconds * 60 minutes * 24 hours * 7 days | ||
| FEE_DISBURSER_ADMIN=0x8937037a0bb08658e5a178c182e60b12f14720ce |
There was a problem hiding this comment.
cast call --rpc-url https://base-sepolia.cbhq.net 0x4200000000000000000000000000000000000018 "owner()"
| BASE_CONTRACTS_COMMIT=8e56038610812dc8411f9fc6ecbef2cba613b913 | ||
|
|
||
| # BalanceTracker configuration | ||
| BALANCE_TRACKER_DEPLOYER=<> |
There was a problem hiding this comment.
I think BALANCE_TRACKER_DEPLOYER and FEE_DISBURSER_DEPLOYER are filled in when the deploy happens?
(the address of the EOA wallet deployer)
There was a problem hiding this comment.
We'd want to allocate a new key for this - let's sync offline!
|
|
||
| # BalanceTracker configuration | ||
| BALANCE_TRACKER_DEPLOYER=<> | ||
| PROFIT_WALLET=<> |
There was a problem hiding this comment.
Not very sure where to find PROFIT_WALLET and OPTIMISM_WALLET for sepolia, would love some hints on this one
There was a problem hiding this comment.
I think you can use what we used for Goerli (0x5a822ea15764a6090b86b1eabffc051cec99afe9) for both values. This is a coinbase managed key
There was a problem hiding this comment.
Although if we're anyways allocating an address for deploying, might be a good idea to allocate a new one here as well
There was a problem hiding this comment.
Updated it to 0x5a822ea15764a6090b86b1eabffc051cec99afe9 for now!
| .PHONY: sign-cb | ||
| sign-cb: | ||
| $(GOPATH)/bin/eip712sign --ledger --hd-paths "m/44'/60'/$(LEDGER_ACCOUNT)'/0/0" -- \ | ||
| forge script UpgradeToFeeDisburser --via-ir --rpc-url $(L2_RPC_URL) UpgradeToFeeDisburser --sig "sign()" | ||
|
|
||
| .PHONY: execute | ||
| execute: | ||
| @forge script UpgradeToFeeDisburser --rpc-url $(L2_RPC_URL) UpgradeToFeeDisburser \ | ||
| --sig "run(bytes)" $(SIGNATURES) --private-key ${PRIVATE_KEY} --sender $(SENDER) |
There was a problem hiding this comment.
Is it possible to run local test for this multisig script? I tried to pass in --private-key $(PRIVATE_KEY) with my own private key and using my wallet address for CB_SAFE_ADDRESS to run sign-cb but it throws Revert error.
Not sure if that's the proper way to do it though
cody-wang-cb
changed the title
cody-wang-cb
changed the title
cody-wang-cb
force-pushed
the
cody/deploy_revshare_sepolia
branch
from
405e0df
to
38078de
Compare
cody-wang-cb
force-pushed
the
cody/deploy_revshare_sepolia
branch
from
44bd211
to
623467a
Compare
|
Review Error for mdehoog @ 2024-01-29 19:00:51 UTC |
Similar to this task https://github.com/base-org/contract-deployments/tree/main/goerli/2023-08-23-deploy-revshare, to deploy revenue share contracts to sepolia.
The contracts are identical to the goerli contracts.
Deployed contracts:
In addition, added another script
UpdateFeeVaultRecipient.s.solto deploy new L2 fee vaults contract in order to point the recipients to theFeeDisburser. This is needed sincerecipientis immutable.This script needs to be ran by the
ProxyAdmin.