implement review changes

mainnet/2024-04-17-upgrade-erc20-factory/README.md

@@ -31,13 +31,6 @@ Make sure your ledger is still unlocked and run the following.
 make sign-op # or make sign-cb for Coinbase signers
 ```
 
-Note: there have been reports of some folks seeing this error `Error creating signer: error opening ledger: hidapi: failed to open device`. A fix is in progress, but not yet merged. If you come across this, open a new terminal and run the following to resolve the issue:
-```
-git clone [email protected]:base-org/eip712sign.git
-cd eip712sign
-go install
-```
-
 Once you run the make sign command successfully, you will see a "Simulation link" from the output.
 
 Paste this URL in your browser. A prompt may ask you to choose a
@@ -59,7 +52,7 @@ message hash to approve on your Ledger then verify completion:
 Make sure you are on the "Overview" tab of the tenderly simulation, to
 validate integrity of the simulation, we need to check the following:
 
-1. "Network": Check the network is Optimism Mainnet.
+1. "Network": Check the network is Base Mainnet.
 2. "Timestamp": Check the simulation is performed on a block with a
  recent timestamp (i.e. close to when you run the script).
 3. "Sender": Check the address shown is your signer account. If not,

mainnet/2024-04-17-upgrade-erc20-factory/foundry.toml

@@ -3,7 +3,7 @@ src = 'src'
 out = 'out'
 libs = ['lib']
 broadcast = 'records'
-fs_permissions = [ {access = "read-write", path = "./"} ]
+fs_permissions = [{ access = "read-write", path = "./" }]
 optimizer = true
 optimizer_runs = 999999
 solc_version = "0.8.19"
@@ -15,7 +15,6 @@ remappings = [
  '@rari-capital/solmate/=lib/solmate/',
  '@base-contracts/=lib/base-contracts',
  'solady/=lib/solady/src/',
- '@agora=lib/optimism-gov/src',
 ]
 
-# See more config options https://github.com/foundry-rs/foundry/tree/master/config
+# See more config options https://github.com/foundry-rs/foundry/tree/master/config

mainnet/2024-04-17-upgrade-erc20-factory/script/RunUpgradeToAndCallERC20Factory.sol

@@ -21,8 +21,6 @@ contract RunUpgradeToAndCallERC20Factory is NestedMultisigBuilder {
  address public ERC20_FACTORY_IMPL = vm.envAddress("ERC20_FACTORY_IMPL");
 
  address internal NESTED_SAFE = vm.envAddress("NESTED_SAFE");
- address internal BASE_SAFE = vm.envAddress("BASE_SAFE");
- address internal OP_SAFE = vm.envAddress("OP_SAFE");
 
  function _postCheck(Vm.AccountAccess[] memory, SimulationPayload memory) internal override {
  address impl = address(uint160(uint256(vm.load(ERC20_FACTORY, IMPLEMENTATION_KEY))));