Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unncessary final, fixes PHP 8 compatibility #173

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove unncessary final, fixes PHP 8 compatibility #173

wants to merge 2 commits into from

Conversation

Seldaek
Copy link

@Seldaek Seldaek commented Dec 9, 2020 •
edited
Loading

Using this library on PHP 8 leads to this warning:

PHP Warning: Private methods cannot be final as they are never overridden by other classes in vendor/php-console/php-console/src/PhpConsole/Connector.php on line 101

This PR fixes that in a less intrusive way than #171

closes #171

@Seldaek
Copy link
Author

Seldaek commented Dec 9, 2020

@barbushin if you have a few minutes to merge and tag a release for this it'd be great.

@justinkruit justinkruit mentioned this pull request Jun 11, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Seldaek