Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update installation in readme #92

Merged
merged 2 commits into from
Nov 29, 2023
Merged

update installation in readme #92

merged 2 commits into from
Nov 29, 2023

Conversation

d-schindler
Copy link
Collaborator

No description provided.

@d-schindler
Copy link
Collaborator Author

What happened to the contrib module? Is it not an extra anymore?

@d-schindler d-schindler requested a review from arnaudon November 20, 2023 11:31
@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (783ff73) 100.00% compared to head (72b8382) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #92   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          642       642           
=========================================
  Hits           642       642           
Flag Coverage Δ
pytest 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arnaudon
Copy link
Collaborator

maybe let's keep both installations, clone and pypi.

@arnaudon
Copy link
Collaborator

What happened to the contrib module? Is it not an extra anymore?

it is installed by default in the main package, as it is not a dependency

@d-schindler
Copy link
Collaborator Author

d-schindler commented Nov 20, 2023

maybe let's keep both installations, clone and pypi.

But then the section get's very long, especially when we go through all the extras again. We could present installation via git, but skip the extras for that one?

@d-schindler
Copy link
Collaborator Author

I added a (slightly modified) description of installation via cloning, have a look!

@d-schindler
Copy link
Collaborator Author

@arnaudon , can we merge this?

@arnaudon
Copy link
Collaborator

Sure, it looks good!

@arnaudon arnaudon merged commit 5d094ad into master Nov 29, 2023
2 checks passed
@arnaudon arnaudon deleted the readme branch November 29, 2023 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants