-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of linearized_directed constructor #70
Conversation
We need to set |
We should have |
I think we need to improve the code for constructors by using more |
@arnaudon , I think this is ready to merge after your improvements. could you e.g. provide a kwarg in run to set the teleportation parameter alpha? |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #70 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 7 7
Lines 552 576 +24
=========================================
+ Hits 552 576 +24
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Here you are! |
Let me know if it's ok, and we can merge! |
Do you keep the print statements on purpose? Also the |
Oups, I just removed them! |
is it good to merge like that @d-schindler ? |
Yes, I think it's fine now! |
Before you merge, could you delete this from benchmarking.py, it's deprecated: |
This PR is to provide linearized MS for directed networks as discussed in #69