fix: make ChiiTimeLine.id type safe

bangumi · Sep 21, 2024 · 2137cd2 · 2137cd2
1 parent 7ab36c0
commit 2137cd2
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/chii/db/tables.py b/chii/db/tables.py
@@ -1,4 +1,3 @@
-import datetime
 import html
 import time
 from dataclasses import dataclass, field
@@ -18,14 +17,17 @@
 reg: registry = registry()
 
 
-@reg.mapped
 @dataclass(kw_only=True)
 class ChiiTimeline:
     __tablename__ = "chii_timeline"
     __sa_dataclass_metadata_key__ = "sa"
 
+    # mysql will generate ID for AUTO_INCREMENT field if value is 0
     id: int = field(
-        init=False, metadata={"sa": Column("tml_id", INTEGER(10), primary_key=True)}
+        default=0,
+        metadata={
+            "sa": Column("tml_id", INTEGER(10), primary_key=True, autoincrement=True)
+        },
     )
     uid: int = field(
         metadata={
@@ -97,12 +99,16 @@ class ChiiTimeline:
                 INTEGER(10),
                 nullable=False,
                 server_default=text("'0'"),
-                default=lambda: int(datetime.datetime.now().timestamp()),
+                default=lambda: int(time.time()),
             )
         },
     )
 
 
+# normally we should just use @reg.mapped
+# but it make pycharm think `ChiiTimeline` is not a dataclasses
+reg.mapped(ChiiTimeline)
+
 # type helper for ChiiTimeline.uid.desc()
 ChiiTimeline_column_id: Column[int] = cast(Column[int], ChiiTimeline.id)
 ChiiTimeline_column_uid: Column[int] = cast(Column[int], ChiiTimeline.uid)
@@ -122,7 +128,6 @@ def process_result_value(self, value, dialect):
         return html.unescape(value)
 
 
-@reg.mapped
 @dataclass(kw_only=True)
 class ChiiSubject:
     __tablename__ = "chii_subjects"
@@ -228,3 +233,6 @@ class ChiiSubject:
     ban: int = field(
         metadata={"sa": Column("subject_ban", TINYINT(1), server_default=text("'0'"))}
     )
+
+
+reg.mapped(ChiiSubject)