Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: subject comments #845

Merged
merged 27 commits into from
Dec 1, 2024
Merged

refactor: subject comments #845

merged 27 commits into from
Dec 1, 2024

Conversation

everpcpc
Copy link
Contributor

@everpcpc everpcpc commented Dec 1, 2024

#831 里面跟 blog 无关的内容拆过来了

Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 80.67568% with 143 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (3c8aa3c) to head (a571c4f).
Report is 22 commits behind head on master.

Files with missing lines Patch % Lines
routes/private/routes/subject.ts 76.72% 71 Missing ⚠️
lib/topic/display.ts 20.68% 22 Missing and 1 partial ⚠️
lib/types/convert.ts 58.33% 20 Missing ⚠️
lib/types/fetcher.ts 76.47% 12 Missing ⚠️
lib/topic/index.ts 71.42% 8 Missing ⚠️
routes/private/routes/post.ts 70.58% 5 Missing ⚠️
lib/types/res.ts 98.36% 1 Missing and 1 partial ⚠️
routes/private/routes/topic.ts 94.28% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #845      +/-   ##
==========================================
- Coverage   69.14%   68.93%   -0.22%     
==========================================
  Files          98      107       +9     
  Lines       15242    16123     +881     
  Branches      799      858      +59     
==========================================
+ Hits        10539    11114     +575     
- Misses       4694     5001     +307     
+ Partials        9        8       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

package.json Outdated
@@ -19,6 +19,7 @@
"start": "nodemon ./bin/main.ts",
"start-cron": "nodemon ./bin/cron.ts",
"test": "vitest --run",
"test-update": "vitest --update",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm run test -u 不就行嘛

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

倒也是……

@trim21 trim21 merged commit 8904e5a into bangumi:master Dec 1, 2024
5 checks passed
@everpcpc everpcpc deleted the fix-comment branch December 1, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants