Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: api for subject related characters & persons #788

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

everpcpc
Copy link
Contributor

@everpcpc everpcpc commented Oct 27, 2024

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 92.82297% with 15 lines in your changes missing coverage. Please review.

Project coverage is 69.87%. Comparing base (75784e9) to head (2e3ff76).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
routes/private/routes/subject.ts 93.45% 11 Missing ⚠️
lib/types/fetcher.ts 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #788      +/-   ##
==========================================
+ Coverage   69.49%   69.87%   +0.38%     
==========================================
  Files          96       96              
  Lines       14962    15149     +187     
  Branches      740      753      +13     
==========================================
+ Hits        10398    10586     +188     
+ Misses       4555     4554       -1     
  Partials        9        9              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@everpcpc everpcpc marked this pull request as ready for review October 27, 2024 11:11
@trim21 trim21 merged commit 6b0206e into bangumi:master Oct 31, 2024
5 checks passed
@everpcpc everpcpc deleted the feat-sub branch October 31, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants