Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better initialisation #13

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Better initialisation #13

merged 2 commits into from
Sep 5, 2024

Conversation

AldoGl
Copy link
Collaborator

@AldoGl AldoGl commented Aug 14, 2024

I improve the initialisation in two ways:

  • I make all the init functions return the initialisation argument. This should make it easier to initialise an extend the model as on can easily recover the default arguments.
  • I refactor from "initialise" to "init" to avoid confusion between English/American spelling and improve conciseness

@Devetak Devetak self-assigned this Sep 5, 2024
@Devetak Devetak self-requested a review September 5, 2024 07:59
@Devetak Devetak removed their assignment Sep 5, 2024
Devetak
Devetak approved these changes Sep 5, 2024
View reviewed changes
Copy link
Collaborator

@Devetak Devetak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Good idea to return the tuple of default arguments.

@AldoGl
Copy link
Collaborator Author

AldoGl commented Sep 5, 2024

Thank you @Devetak!

@AldoGl AldoGl merged commit b92982a into main Sep 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Devetak Devetak Devetak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AldoGl @Devetak