Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace caverealms_lite and xdecor #960

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

waxtatect
Copy link
Collaborator

@waxtatect waxtatect commented Jan 19, 2025

i must say i miss original caverealms with the big colorful caves, maybe with some bits of lava and the fortresses/fountains.

2

1

anyways...

"caverealms:glow_obsidian_glass" is already added to the circular saw in tenplus1's fork,
https://codeberg.org/tenplus1/caverealms_lite/src/commit/53748442b035d96790593b8967f192eb6ac95760/stairs.lua#L157

i can't tell which is the best looking one, obsidian glow glass/obsidian glass

5

"caverealms:glow_obsidian_brick", "caverealms:glow_obsidian_brick_2" are new blocks added to the circular saw, a bit buggy for glow_obsidian_brick

4

"caverealms:constant_flame" will turn into "fire:permanent_flame", not sure it'll change anything,

https://codeberg.org/tenplus1/caverealms_lite/src/commit/53748442b035d96790593b8967f192eb6ac95760/nodes.lua#L439

(now i wonder what changes i missed) it seems it should be fine to switch caverealms_lite

edit: i forgot, https://codeberg.org/tenplus1/caverealms_lite/src/commit/53748442b035d96790593b8967f192eb6ac95760/config.lua#L21, the value was in original caverealms_lite -33000, could be restored with caverealms.ymin = -33000 in conf file
edit2: about xdecor-libre, https://codeberg.org/Wuzzy/xdecor-libre.git
xdecore:stone_tile (alias) -> xdecore:stone_tile_x
xdecore:wood_tile (alias) -> xdecore:wood_tile_x
xdecor:lantern_hanging (new node)
(not including changes i missed)

@waxtatect
Copy link
Collaborator Author

waxtatect commented Jan 19, 2025

those missing nodes were probably registered for xdecor:workbench, and aren't anymore for reasons...
edit:
would it be simply mods loading orders?
https://github.com/minetest-mods/xdecor/blob/8b614b3513f2719d5975c883180c011cb7428c8d/src/workbench.lua#L11
https://github.com/minetest-mods/xdecor/blob/8b614b3513f2719d5975c883180c011cb7428c8d/handlers/helpers.lua#L43
for caverealms:stone_with_algae, the only difference is having the group stone = 3
edit2: removing moreblocks optional_depends in caverealms_lite/mod.conf might fix it

@waxtatect
Copy link
Collaborator Author

i don't know what i can do to fix the check. idea, fork xdecor and add caverealms to optional_depends and hope it doesn't break something else. other idea, switch to xdecor-libre https://codeberg.org/Wuzzy/xdecor-libre, and enjoy making a list of all the nodes to register with the workbench.

@waxtatect waxtatect changed the title replace caverealms_lite replace caverealms_lite and xdecor Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant