Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/4699 sort custom filament dropdowns #4700

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/4699 sort custom filament dropdowns #4700

wants to merge 2 commits into from

Conversation

longrackslabs
Copy link

Fixes #4699

  • Sort filament vendors alphabetically
  • Sort filament type alphabetically
  • Clean up vendor names to have consistent upper/lower case
    image (3)
    image (2)

@DanBao-Bambu
Copy link
Contributor

Some of the all capitalized spellings in the vendor field are due to the fact that the official website itself is capitalized, and the existing vendor field has been maintained by the internal system, and any changes may cause inconvenience to other users.

@longrackslabs
Copy link
Author

longrackslabs commented Sep 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanBao-Bambu DanBao-Bambu Awaiting requested review from DanBao-Bambu

@bambu123 bambu123 Awaiting requested review from bambu123

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom Filament vendor name and filament type should sort alphabetically
2 participants
@longrackslabs @DanBao-Bambu