Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Change #4047

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

New Change #4047

wants to merge 2 commits into from

Conversation

HYzd766
Copy link
Contributor

@HYzd766 HYzd766 commented May 13, 2024

We have mainly made modifications to printing consumables. Through testing, some parameters of consumables have been modified and new consumables have been added for everyone to choose from. The selection of consumables has also become more neat and regular. In addition, minor changes have been made to the machine configuration parameters.

@QingZhangBambu
Copy link
Collaborator

@HYzd766 We have strict rules for setting_id and generic filament names, I will change it to make sure it complies

@QingZhangBambu
Copy link
Collaborator

@HYzd766 If the parameters are compatible, I'll merge the files. For example:
image

@HYzd766
Copy link
Contributor Author

HYzd766 commented May 16, 2024

如果参数兼容,我将合并文件。例如: 图像

Okay, all parameters are compatible. Thank you for your review.

@QingZhangBambu
Copy link
Collaborator

QingZhangBambu commented May 16, 2024

@HYzd766
你好,请问这是一款什么料。是属于ABS-GF料的种类吗?后面的ABS-GF25呢?
image

@HYzd766
Copy link
Contributor Author

HYzd766 commented May 16, 2024

@QingZhangBambu
It and ABS-GF25 are both ABS materials; But when mixed with fiberglass, the number represents the fiberglass content.

@QingZhangBambu
Copy link
Collaborator

OK, 那这些呢,我需要跟你确认一下他们所属的材料种类
image

@HYzd766
Copy link
Contributor Author

HYzd766 commented May 16, 2024

@QingZhangBambu
PA-Ultra和PA12-CF属于尼龙材料;PC-ABS-FR属于PC和ABS混合材料一般用于阻燃

@QingZhangBambu
Copy link
Collaborator

PA-Ultra和PA12-CF属于尼龙材料;PC-ABS-FR属于PC和ABS混合材料一般用于阻燃

不,我的意思是说,PA-Utra是属于PA类材料吗?PC-ABS-FP属于PC材料吗?我需要根据材料归属来确认如何分配他们的filament id

@HYzd766
Copy link
Contributor Author

HYzd766 commented May 16, 2024

@QingZhangBambu
好的。PA-Utra是属于PA类材料,PC-ABS-FP属于PC材料。

@QingZhangBambu
Copy link
Collaborator

@QingZhangBambu 好的。PA-Utra是属于PA类材料,PC-ABS-FP属于PC材料。

image
但是看起来PC-ABS-FR是依据abs材料的基础信息建立,请确认一下这个材料的种类

@HYzd766
Copy link
Contributor Author

HYzd766 commented May 17, 2024

@QingZhangBambu 经过确认,PC-ABS-FR属于ABS材料类

@QingZhangBambu
Copy link
Collaborator

@HYzd766 好的,非常感谢。我会查看新增所有材料,确认我们的相关材料映射是否支持。一些暂时不支持的材料我稍后会告知您。支持的材料后续会被合入。

@QingZhangBambu
Copy link
Collaborator

@HYzd766 您好,我已经审阅完了所有文件,由于需要更改的点过多,所以希望您能进行修改,如下:

  1. 不要删除原有的文件
  2. 不要修改原有的文件的名称
  3. 请清理预设文件内容,和父文件相同的参数,在子文件内不必写入,保证文件的干净规整
  4. 预设文件内容请保证规则,使用空格代替tab,保证参数左对齐,在文件开始放置"type","name","inherits","from","setting_id","instantation"的格式,其他文件格式请参考BBL, 参考格式图片如下:

image

  1. PA-12-CF, PC-ABS-FP, PETG ECO这几种料经过确认后系统暂时不支持,请去除相关预设,等后续支持后再提交
  2. 文件名称上请保持厂商名称的一致性,大小写统一 例如都使用QIDI+xxx @Qidi, 或者都使用Qidi + xxx @Qidi,不要两者混用
  3. process 预设和 filament 预设的名称需要符合规范,多种机器一起使用的预设,取一个通用的名称,否则使用具体的机器类型
    process 预设名称规范为:层高+预设名称+@+厂商名 + (机器类型)
    filament 预设Generic 材料名称规范为:Generic +材料名称+@+厂商名 + (机器类型)
    filament 预设厂商的材料名称规范为:厂商名+材料名称+@+厂商名 + (机器类型)
  4. 对于process 预设和 filament 预设,如果两个机型的参数相同,在compatible_printers 下增加打印机机型即可,不要新建预设
    这里是一个举例改动:

image
image

  1. 新增的machine 预设需要分配setting_id, id规则为:GM_厂商名_三位计数,setting_id不可重复。举例原有的setting_id已经是GM_Qidi_009, 则新建的文件的setting_id由GM_Qidi_010开始递增。
  2. 新增的process 预设需要分配setting_id, id规则为:GP_厂商名_三位计数
  3. 新增的filament 预设需要分配setting_id 和 filament_id
    setting_id 规则为:filament_id前两位+S+剩余位数_厂商名_两位计数, 举例: GFSB98_Qidi_02, GFB98为材料filament_id,在第三位插入S,
    filament_id 请使用已有的材料种类的filament_id,可在BBL预设文件内自行查找,例如Bambu PET-CF的filament_id是GFT01, 请在Qidi PET-CF文件内使用GFT01作为filament_id
  4. 保证Qidi.json的文件中的文件路径顺序,父文件在前,子文件在后,否则会造成预设载入失败,无法展示材料和预设以及机型的问题。

以上是需要改动的内容,改动后删除system 文件夹后进行编译后可以测试预设是否生效,若不生效,则检测是否有文件路径遗漏,文件名填写错误的问题。
image
文件较多容易出错的话,可以分多次提交合入,提高效率

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants