sfeakes#135: Buffer overflow in action_web_request

ballle98 · Aug 7, 2023 · efd2aa1 · efd2aa1
1 parent 4d7322a
commit efd2aa1
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/net_services.c b/net_services.c
@@ -1493,8 +1493,8 @@ void action_web_request(struct mg_connection *nc, struct http_message *http_msg)
       mg_send_head(nc, 200, strlen(GET_RTN_UNKNOWN), CONTENT_TEXT);
       mg_send(nc, GET_RTN_UNKNOWN, strlen(GET_RTN_UNKNOWN));
     }
-
-    sprintf(buf, "action_web_request() request '%.*s' took",(int)http_msg->uri.len, http_msg->uri.p);
+    snprintf(buf, sizeof(buf), "action_web_request() request '%.*s' took",
+             (int)http_msg->uri.len, http_msg->uri.p);
 
     DEBUG_TIMER_STOP(tid, NET_LOG, buf);
   }
@@ -2049,4 +2049,4 @@ bool start_net_services(/*struct mg_mgr *mgr, */struct aqualinkdata *aqdata)
   return true;
 }
 
-#endif
+#endif