sfeakes#135: Buffer overflow in action_web_request

ballle98 · Jun 15, 2023 · 8fba38b · 8fba38b
1 parent c1a4eef
commit 8fba38b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/net_services.c b/net_services.c
@@ -1399,8 +1399,8 @@ void action_web_request(struct mg_connection *nc, struct http_message *http_msg)
       mg_send_head(nc, 200, strlen(GET_RTN_UNKNOWN), CONTENT_TEXT);
       mg_send(nc, GET_RTN_UNKNOWN, strlen(GET_RTN_UNKNOWN));
     }
-
-    sprintf(buf, "action_web_request() request '%.*s' took",(int)http_msg->uri.len, http_msg->uri.p);
+    snprintf(buf, sizeof(buf), "action_web_request() request '%.*s' took",
+             (int)http_msg->uri.len, http_msg->uri.p);
 
     DEBUG_TIMER_STOP(tid, NET_LOG, buf);
   }
@@ -2407,4 +2407,4 @@ void OLD_action_websocket_request(struct mg_connection *nc, struct websocket_mes
   } 
 }
 
-#endif // INCLUDE_V1_API
+#endif // INCLUDE_V1_API