Enable tool update only for valid distributions #234
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #234 +/- ##
============================================
- Coverage 61.95% 61.91% -0.05%
Complexity 212 212
============================================
Files 20 20
Lines 1154 1158 +4
Branches 154 156 +2
============================================
+ Hits 715 717 +2
- Misses 353 354 +1
- Partials 86 87 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
SonarCloud Quality Gate failed.
|
keizer619
reviewed
Jan 8, 2024
| @@ -443,6 +443,9 @@ public static boolean downloadDistribution(PrintStream printStream, String distr | |||
| conn.setRequestProperty("testMode", "true"); | |||
| } | |||
| if (conn.getResponseCode() == 302) { | |||
| if (!testMode) { | |||
There was a problem hiding this comment.
I am wondering should we commit this code as it will be executed in prod as well?
Ideally this could be coming from a diff/patch file where it has to be applied in order to test locally
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Enable updating the tool version to the latest in pull command only for valid distributions.
Goals
fixes #233