Sending semtype changes to master #43606
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump nutcracker to match master
Since #35886 has been addressed, we should be able to remove the temporary shape check workaround. Please refer to #35872 (comment)
Previously ballerina `readonly` return type allowed for java void methods. However, `error?` was not allowed with java void. This inconsistency is due to type checking not recognizing the fact that readonly type does include the error type. The error given in the latter case too is wrong because error is optional.
Previously this was implemented with a temporary workaround which was inefficient as we recalculated the semtypes.
Please refer to #43344 (comment) for the reason
Implement runtime type checker on SemTypes
lochana-chathura
requested review from
gimantha,
MaryamZi,
KavinduZoysa,
warunalakshitha,
azinneera,
NipunaRanasinghe,
sameerajayasoma and
hasithaa
as code owners
lochana-chathura
changed the title
lochana-chathura
force-pushed
the
nutcracker
branch
5 times, most recently
from
54adcc3
to
ac28a08
Compare
This will fix the ModuleExecutionFlowTests tests failures on top of the semtype runtime changes. My guess is now that runtime faster with semtypes, a faster reading rate is required.
lochana-chathura
force-pushed
the
nutcracker
branch
from
ac28a08
to
7a51dad
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject.
Fixes #40474
Approach
n/a
Samples
n/a
Remarks
n/a
Check List