Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java21] Fix failing full build #43465

Merged
merged 6 commits into from
Oct 8, 2024
Merged

[java21] Fix failing full build #43465

merged 6 commits into from
Oct 8, 2024

Conversation

HindujaB
Copy link
Contributor

@HindujaB HindujaB commented Oct 7, 2024 •
edited
Loading

Purpose

$subject

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@HindujaB HindujaB marked this pull request as draft October 7, 2024 09:25
@HindujaB HindujaB marked this pull request as ready for review October 7, 2024 09:26
@HindujaB HindujaB closed this Oct 7, 2024
@HindujaB HindujaB reopened this Oct 8, 2024
@HindujaB HindujaB changed the title [WIP] Add temp change [java21] Fix failing full build Oct 8, 2024
warunalakshitha
warunalakshitha approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit bd9191f into ballerina-platform:java21 Oct 8, 2024
5 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warunalakshitha warunalakshitha warunalakshitha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HindujaB @warunalakshitha