Implement function semtype in runtime #43140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heshanpadmasiri
force-pushed
the
feat/runtime-function
branch
from
0089bf2
to
5b8e3dd
Compare
Avoid repeated type creation
Cache int singleton creation
Use new api in CompilerTypeTestApi Extract out the which semtype implementation used for tests Implement semtype tests
Fix doc comments
Widened type for basic types is the basic type where as for other types it is contextually expected type (not the actual shape of the value). This is to avoid the overhead of having to create singleton types for each basic type value
Due to reasons that are not entierly clear to me when we run all the unit tests some how types from `record_project_closed_rec_equiv` to clashed with types defined in other unit tests. As a temperary workaround I introduced a new package name for this.
heshanpadmasiri
force-pushed
the
feat/runtime-function
branch
from
5b8e3dd
to
a3fe87e
Compare
|
This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the |
|
Closed PR due to inactivity for more than 18 days. |
13 tasks
|
Closed in favour of #43279 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
$subject
Fixes #43107
Approach
Samples
Remarks
Check List