-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2201.11.0] Update OpenAPI changes for U11 #9622
Open
lnash94
wants to merge
1
commit into
ballerina-platform:release-2201.11.0
Choose a base branch
from
lnash94:u11-openapi-release-note
base: release-2201.11.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[2201.11.0] Update OpenAPI changes for U11 #9622
lnash94
wants to merge
1
commit into
ballerina-platform:release-2201.11.0
from
lnash94:u11-openapi-release-note
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnash94
force-pushed
the
u11-openapi-release-note
branch
from
November 28, 2024 10:18
bf6e22d
to
2367cbe
Compare
daneshk
reviewed
Nov 28, 2024
Comment on lines
+72
to
+74
- Introduced the `sanitize` sub-command, which sanitizes the OpenAPI contract file according to Ballerina's best | ||
naming practices. The Ballerina name extensions are added to the schemas which can not be modified directly. | ||
The output is a modified OpenAPI contract. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- Introduced the `sanitize` sub-command, which sanitizes the OpenAPI contract file according to Ballerina's best | |
naming practices. The Ballerina name extensions are added to the schemas which can not be modified directly. | |
The output is a modified OpenAPI contract. | |
- Introduced the `sanitize` sub-command, which sanitizes the OpenAPI contract file according to Ballerina's best naming practices. The Ballerina name extensions are added to the schemas, which can not be modified directly. | |
The output is a modified OpenAPI contract. |
daneshk
reviewed
Nov 28, 2024
Comment on lines
+79
to
+80
- Add code generation support with the new Ballerina name extensions. These extensions are mapped as relevant | ||
annotations in the generated types, parameters and record fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- Add code generation support with the new Ballerina name extensions. These extensions are mapped as relevant | |
annotations in the generated types, parameters and record fields. | |
- Added code generation support with the new Ballerina name extensions. These extensions are mapped as relevant annotations in the generated types, parameters, and record fields. |
daneshk
reviewed
Nov 28, 2024
Comment on lines
+118
to
+119
- Added support for relaxed data binding on the client side payload. This enables, `nil` values are treated as optional, | ||
and absent fields are handled as `nilable` types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
- Added support for relaxed data binding on the client side payload. This enables, `nil` values are treated as optional, | |
and absent fields are handled as `nilable` types. | |
- Added support for relaxed data binding on the client-side payload. This enables `nil` values to be treated as optional, and absent fields are handled as `nilable` types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Checklist
Page addition
permalink
to pages.Page removal
redirect_from
on the alternative page.redirections.js
file.Page rename
redirect_from
.redirect_to:
(if applicable).Page restrcuture
permalink
to pages.redirect_from
.redirect_to:
(if applicable).