Add artifacts support #1189
Open
Add artifacts support #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vipulgupta2048
previously requested changes
Jun 19, 2024
Change-type: patch Signed-off-by: Alex Gonzalez <[email protected]>
Artifacts are needed to program some device types, like the CM4 with secure boot support. Change-type: patch Signed-off-by: Alex Gonzalez <[email protected]>
There was a problem hiding this comment.
Several clarifications,
- Are we hoping to send several artifacts in the future? If it's a singular folder or file, then would it be better to call it
artifactortestArtifactorextraArtifact - Adding it here in the e2e suite.js wouldn't have an effect since there is no
artifactsproperty in the suites/config.js
- Either we add it to config.js and it gets tested in the e2e tests of leviathan
- Or we don't add it at all in the e2e tests.
I have introduced this in the config.js schema so at least it won't error out when the client processes it.
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
Signed-off-by: Vipul Gupta (@vipulgupta2048) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.