Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: allow for balena machine ssh target #1011

Merged
merged 2 commits into from
Jul 18, 2023
Merged

core: allow for balena machine ssh target #1011

merged 2 commits into from
Jul 18, 2023

Conversation

rcooke-warwick
Copy link
Contributor

@rcooke-warwick rcooke-warwick commented Jun 29, 2023 •
edited
Loading

Change-type: patch

The cloud and worker objects can now be initialised with an sshConfig

sshConfig: {
		host: 'ssh.devices.bm.balena-dev.com',
		port: '222',
	}

which can be added to the suites config.js and passed through to these objects in the test suite

@vipulgupta2048 vipulgupta2048 changed the title allow for balena machine ssh target core: allow for balena machine ssh target Jun 30, 2023
@rcooke-warwick rcooke-warwick marked this pull request as ready for review July 3, 2023 09:54
@rcooke-warwick rcooke-warwick force-pushed the ryan/ssh-bm branch 2 times, most recently from d929af3 to 20029d8 Compare July 3, 2023 09:59
@flowzone-app flowzone-app bot enabled auto-merge July 3, 2023 10:01
@rcooke-warwick rcooke-warwick marked this pull request as draft July 3, 2023 12:40
auto-merge was automatically disabled July 3, 2023 12:40

Pull request was converted to draft

@rcooke-warwick
Copy link
Contributor Author

going to keep in draft until tested with all 3 OS test suites

@rcooke-warwick rcooke-warwick force-pushed the ryan/ssh-bm branch 2 times, most recently from 7927fa1 to 50ecb15 Compare July 3, 2023 12:47
@rcooke-warwick rcooke-warwick mentioned this pull request Jul 3, 2023
Merged
6 tasks
@rcooke-warwick
Copy link
Contributor Author

now needs this: #1013 to work with jenkins

@rcooke-warwick rcooke-warwick marked this pull request as ready for review July 18, 2023 10:38
@rcooke-warwick
core: allow configurable ssh target
3b72e49 
Change-type: patch
Signed-off-by: Ryan Cooke <[email protected]>
@rcooke-warwick
update e2e tests to use sshconfig
1f44580 
Change-type: patch
Signed-off-by: Ryan Cooke <[email protected]>
@flowzone-app flowzone-app bot enabled auto-merge July 18, 2023 10:59
@rcooke-warwick
Copy link
Contributor Author

@balena-ci I self-certify!

@flowzone-app flowzone-app bot merged commit 26f4c6b into master Jul 18, 2023
51 checks passed
@flowzone-app flowzone-app bot deleted the ryan/ssh-bm branch July 18, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipulgupta2048 vipulgupta2048 vipulgupta2048 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcooke-warwick @vipulgupta2048