Add on notification listener support #793
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshbwlng
force-pushed
the
joshbwlng/listener
branch
from
07d40e4
to
0b0f875
Compare
joshbwlng
commented
Aug 20, 2024
| channel: string, | ||
| fn: (...args: any[]) => Promise<void>, | ||
| ) { | ||
| let listenerClient: Pg.PoolClient | null = null; |
There was a problem hiding this comment.
This needs to live outside the listen function so we share the client across notification listeners rather than using a separate client from the pool for each listener
Change-type: minor
joshbwlng
force-pushed
the
joshbwlng/listener
branch
from
0b0f875
to
7c87023
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: minor