V2 state get wo si #1853
Draft
V2 state get wo si #1853
+30
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otaviojacobi
force-pushed
the
v2-state-get-wo-si
branch
4 times, most recently
from
b919216
to
e717d88
Compare
Change-type: patch
otaviojacobi
force-pushed
the
v2-state-get-wo-si
branch
from
e717d88
to
a70256a
Compare
otaviojacobi
commented
Nov 24, 2024
| device_service_environment_variable: { | ||
| $select: ['name', 'value'], | ||
| $filter: { | ||
| device: { |
There was a problem hiding this comment.
We need this $filter (or some variation of it) as otherwise the expand will get all device_service_environment_variable for that server and ignore the device filter
There was a problem hiding this comment.
Some other idea would be to directly expand from the device on the top level to dsev but then we need to do something similar for service (which isa bit longer)
otaviojacobi
commented
Nov 24, 2024
| @@ -5,5 +5,12 @@ | |||
| "service": "app1_service1", | |||
| "name": "name_si", | |||
| "value": "value_si" | |||
| }, | |||
| "si2_svc": { | |||
There was a problem hiding this comment.
This forces the state get tests to consider the case why I added the $filter on the device expand above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.