Ignore host app service installs for device service env vars #1499
+42
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e on releases that belong to the device's app Change-type: patch
otaviojacobi
force-pushed
the
ignore-host-app-si
branch
from
24e60ea
to
213b2f0
Compare
thgreasi
reviewed
Nov 22, 2024
| @@ -2984,31 +2997,25 @@ const getDeviceModel = function ( | |||
| ): Promise<void> { | |||
| value = String(value); | |||
|
|
|||
| let deviceFilter; | |||
| if (isId(uuidOrId)) { | |||
There was a problem hiding this comment.
It would be great if we could preserve this optimization, since I think the UI relies on it to make less requests.
Other than that LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch
Contributor checklist