Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hostname-vars: Ensure previous hostname envvars aren't overwritten #79

Merged
merged 1 commit into from
Mar 14, 2019

Conversation

hedss
Copy link
Contributor

@hedss hedss commented Mar 14, 2019

Connects-to: #78
Change-type: major
Signed-off-by: Heds Simons [email protected]

@ghost ghost assigned hedss Mar 14, 2019
@ghost ghost added the review label Mar 14, 2019
@hedss hedss force-pushed the 78-fix-hostname-setting branch 2 times, most recently from decdaab to 530678e Compare March 14, 2019 16:00
@hedss hedss changed the title WIP: hostname-vars: Ensure previous hostname envvars aren't overwritten hostname-vars: Ensure previous hostname envvars aren't overwritten Mar 14, 2019
Connects-to: #78
Change-type: major
Signed-off-by: Heds Simons <[email protected]>
Copy link
Contributor

@wrboyce wrboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@richbayliss richbayliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hedss hedss merged commit 15a34a9 into master Mar 14, 2019
@hedss hedss deleted the 78-fix-hostname-setting branch March 14, 2019 16:11
@ghost ghost removed the review label Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants