Fix folder symbolic link traversing in Windows #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-type: patch
thgreasi
force-pushed
the
thgreasi-patch-1
branch
from
6a13e52
to
6cff36b
Compare
pdcastro
reviewed
Dec 14, 2021
| // Ignore unusual errors while reading directories. | ||
| // Avoids EPERM scandir errors in Windows. | ||
| // See: https://github.com/isaacs/node-glob/issues/284 | ||
| strict: false, |
There was a problem hiding this comment.
This could in theory mask errors that a developer might wish to be warned about (e.g. actual permission errors), however presumably such errors would also affect the functioning of the application or the CI builds/tests and should be caught by testing rather than linting, so I think it is a fair enough workaround to a node-glob issue. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-type: patch
See: https://ci.product-os.io/teams/main/pipelines/github-events-balena-io/jobs/node-cli/builds/93