Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for node < v18 #33

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Drop support for node < v18 #33

merged 4 commits into from
Dec 20, 2023

Conversation

thgreasi
Copy link
Collaborator

@thgreasi thgreasi commented Dec 19, 2023 •
edited
Loading

Change-type: major

@thgreasi thgreasi changed the title Update dependencies Drop support for node < v18 Dec 19, 2023
fisehara
fisehara reviewed Dec 20, 2023
View reviewed changes
Copy link

@fisehara fisehara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing folder .husky for husky v8
  • is the upstream usage save to be bumped to node v18?

@thgreasi
Copy link
Collaborator Author

  • Ooops, I thought that husky install would do the trick, but I guess I was using a migrator mpx command in the past...
  • Yes, the sdk is already requiring node 18

@fisehara
Copy link

LGTM

@thgreasi thgreasi merged commit 092dce1 into master Dec 20, 2023
50 checks passed
@thgreasi thgreasi deleted the balena-lint branch December 20, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fisehara fisehara fisehara approved these changes

@otaviojacobi otaviojacobi Awaiting requested review from otaviojacobi

@JSReds JSReds Awaiting requested review from JSReds

@myarmolinsky myarmolinsky Awaiting requested review from myarmolinsky

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thgreasi @fisehara