Fix URL parsing and validation on Credentials

README.md

@@ -86,5 +86,8 @@ Changelogs:
 - 1.4.6 (13 August 2024)
  * Fix module pre-register checking for directus 11
  * Fix run flow webhook wrong method
+- 1.4.7 (25 August 2024)
+ * Fix URL parsing and validation on Credentials. Now you can use the full URL with the protocol and it will be validated and parsed correctly
+
 Contributing:
 If you want to contribute kindly to create a PR and if you want to request a feature or report of a bug kindly create the Issue

package.json

@@ -2,7 +2,7 @@
  "name": "directus-extension-flow-manager",
  "description": "This is a custom module for managing Flow",
  "icon": "extension",
- "version": "1.4.6",
+ "version": "1.4.7",
  "author": {
  "name": "Bagus Andreanto",
  "email": "[email protected]"

src/flow-manager-module/components/credential-dialog.vue

@@ -36,6 +36,8 @@ const isPreviousIdPersisted = ref(false);
 const isPullingFlows = ref(false);
 const isPullingFlowError = ref(false);
 
+const errors = ref<string[]>([]);
+
 const selectedCredential = ref<ICredential>({
  id: "",
  name: "",
@@ -85,12 +87,25 @@ const flowManagerUtils = inject<{
 }>("flowManagerUtils");
 
 function saveCredential() {
+ let credentialUrlParsed = credentialUrl.value;
+ try {
+ const url = new URL(credentialUrlParsed);
+ if (!url.origin || url.origin === "null") {
+ errors.value = ["Invalid URL"];
+ return;
+ }
+ credentialUrlParsed = url.origin;
+ errors.value = [];
+ } catch (error) {
+ errors.value = ["Invalid URL"];
+ return;
+ }
  if (isEdit.value) {
  const newCredentials = [...credentials.value];
  const credentialIndex = newCredentials.findIndex((credential) => credential.id === selectedCredential.value.id);
  if (credentialIndex !== -1) {
  (newCredentials[credentialIndex] as ICredential).name = credentialName.value;
- (newCredentials[credentialIndex] as ICredential).url = credentialUrl.value;
+ (newCredentials[credentialIndex] as ICredential).url = credentialUrlParsed;
  if (credentialStaticToken.value) {
  (newCredentials[credentialIndex] as ICredential).staticToken = credentialStaticToken.value;
  } else {
@@ -116,7 +131,7 @@ function saveCredential() {
  {
  id: generateRandomString(10),
  name: credentialName.value,
- url: credentialUrl.value,
+ url: credentialUrlParsed,
  staticToken: credentialStaticToken.value,
  },
  ];
@@ -276,6 +291,12 @@ async function proceedPull() {
  v-tooltip.bottom="'Credential Static Token'"
  class="input-form"
  ></v-input>
+ <v-error
+ v-for="(error, indexError) in errors"
+ class="mb-2"
+ :key="`errorIndex-${indexError}`"
+ :error="{ extensions: { code: 'Error' }, message: error }"
+ ></v-error>
  <v-button :disabled="!isValid" @click="saveCredential">
  {{ isEdit ? "Save" : "Add" }}
  </v-button>
@@ -323,6 +344,9 @@ async function proceedPull() {
  margin-left: 10px;
 }
 
+.mb-2 {
+ margin-bottom: 10px;
+}
 .container > .v-card.card-extended {
  --v-card-min-width: 1000px;
 }