Raise non-fatal error if node called outside main thread #386

LachlanMcKee · 2023-03-15T16:53:22Z

Description:
Trigger RIBs.ErrorHandler#handleNonFatalError whenever a RIB node is interacted with off the main thread.

CherryPerry · 2023-03-15T17:06:12Z

libraries/rib-base/src/main/java/com/badoo/ribs/core/Node.kt

@@ -48,6 +49,7 @@ open class Node<V : RibView> @VisibleForTesting internal constructor(
 val buildParams: BuildParams<*>,
 private val viewFactory: ViewFactory<V>?,
 private val retainedInstanceStore: RetainedInstanceStore,
+ private val isOnMainThreadFunc: () -> Boolean,


We need to make it overridable for every junit tested Node in our codebase, which does not seem achievable.

In general makes sense (we do not support any multi-threading anyway, comparing to Appyx which is guarded by coroutines context and/or atomic mutable states).

Let's take a default implementation from RIBs singleton and add RIBs.isOnMainThread and try to override it somehow in tests, potentially in NodeTestHelper and InteractorTestHelper? But the problem there that we do not reset them. (Maybe it is ok just to give up and override always without reset).

Raise fatal error if node called outside main thread

87f6728

LachlanMcKee changed the title ~~Raise fatal error if node called outside main thread~~ Raise non-fatal error if node called outside main thread Mar 15, 2023

CherryPerry reviewed Mar 15, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Raise non-fatal error if node called outside main thread #386

Raise non-fatal error if node called outside main thread #386

LachlanMcKee commented Mar 15, 2023

CherryPerry Mar 15, 2023

Raise non-fatal error if node called outside main thread #386

Are you sure you want to change the base?

Raise non-fatal error if node called outside main thread #386

Conversation

LachlanMcKee commented Mar 15, 2023

CherryPerry Mar 15, 2023

Choose a reason for hiding this comment