Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstraction layer for database and filesystem #46

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Add abstraction layer for database and filesystem #46

merged 5 commits into from
Jan 2, 2025

Conversation

francisduvivier
Copy link
Collaborator

@francisduvivier francisduvivier commented Dec 29, 2024 •
edited
Loading

See commits, relates to issue #43

@francisduvivier francisduvivier linked an issue Dec 29, 2024 that may be closed by this pull request
Add abstraction layer for Database and Filesystem #43
Closed
@francisduvivier francisduvivier changed the title Add abstraction layer for database and filesystem 43 Add abstraction layer for database and filesystem Dec 29, 2024
@francisduvivier francisduvivier changed the title 43 Add abstraction layer for database and filesystem #43 Add abstraction layer for database and filesystem Dec 29, 2024
@francisduvivier francisduvivier changed the title #43 Add abstraction layer for database and filesystem Add abstraction layer for database and filesystem Dec 29, 2024
Francis Duvivier added 2 commits December 29, 2024 19:46
Add extra abstraction layer for separating files stuff and DB stuff w…
5169ad2 
…ith some sample for file stuff

File stuff will still change later though when we are actually implementing file management
Move wait to build.yml since otherwise the npm command is not working…
49ea19e 
… with podman
@francisduvivier francisduvivier force-pushed the 43-add-abstraction-layer-for-database-and-filesystem branch from 939f690 to 49ea19e Compare December 29, 2024 18:46
edwinm
edwinm requested changes Dec 29, 2024
View reviewed changes
Copy link
Collaborator

@edwinm edwinm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See build failure due to
Property 'writeDraftFile' does not exist on type 'PostgreSQLBadgeHubMetadata'.

at src/setupPopulateDBApi.ts line 335

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 34.14% 790 / 2314
🔵 Statements 34.14% 790 / 2314
🔵 Functions 35.87% 47 / 131
🔵 Branches 83.05% 49 / 59
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/setupPopulateDBApi.ts 0% 0% 0% 0% 1-384
src/controllers/private-rest.ts 37.17% 100% 0% 37.17% 22-26, 33-38, 45-49, 56-57, 64-68, 75-80, 87-91, 98-102, 109-112, 119-123, 130-131
src/controllers/public-rest.ts 41.55% 100% 22.22% 41.55% 46-47, 54-65, 72-82, 89-93, 100-105, 112-115, 122-126
src/domain/BadgeHubData.ts 24.76% 100% 10.52% 24.76% 23-24, 27-28, 31-35, 39-40, 45-46, 49-50, 53-54, 57-58, 61-62, 65-78, 81-86, 93-94, 101-103, 106-119, 122-125, 128-140, 143-148
src/domain/BadgeHubFiles.ts 100% 100% 100% 100%
src/domain/readModels/app/User.ts 100% 100% 100% 100%
src/fs/NodeFSBadgeHubFiles.ts 50% 100% 0% 50% 5-6, 9-10
Generated in workflow #93 for commit f6b1e6f by the Vitest Coverage Report Action

@francisduvivier francisduvivier merged commit f04d4e8 into main Jan 2, 2025
3 checks passed
@francisduvivier francisduvivier deleted the 43-add-abstraction-layer-for-database-and-filesystem branch January 2, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwinm edwinm edwinm requested changes

@paulinevos paulinevos Awaiting requested review from paulinevos

@zera1ul zera1ul Awaiting requested review from zera1ul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add abstraction layer for Database and Filesystem
2 participants
@francisduvivier @edwinm