Upload API Prep Part 4: Fix prod #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisduvivier
requested review from
edwinm,
zera1ul and
pitastrudl
and removed request for
edwinm and
zera1ul
francisduvivier
force-pushed
the
feature/26-upload-api-part-3
branch
from
102bf05 to
79342cb
Compare
francisduvivier
force-pushed
the
feature/26-upload-api-part-4_fix-prod
branch
from
fed1bc2 to
99ef4e6
Compare
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
francisduvivier
force-pushed
the
feature/26-upload-api-part-4_fix-prod
branch
from
99ef4e6 to
faf95a0
Compare
…run mulpile instances again
francisduvivier
changed the title
|
Closed because I merged it into the PR that was breaking the prod docker compose in the first place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the production docker compose setup.
The problem was that path aliases did not work and that all imports needed extensions.
The fix is by just using tsx in prodution, same like in development, but then without --watch.
In order for the migrations not to to interfere with each other when using multiple instances, I also added a db managed lock around the migrations script run. So even though we run db-migrate at startup, it's not a problem if we start up 4 processes.