Upload API Prep Part 2: Refactor database and api to new table format #35
Conversation
francisduvivier
commented
Nov 27, 2024
francisduvivier
commented
- Includes adding and using the sql-template-tag package, for increased safety and readability of sql code.
- Includes putting domain layer between api and db, ddd style
francisduvivier
changed the title
francisduvivier
changed the title
francisduvivier
changed the title
francisduvivier
changed the title
francisduvivier
changed the title
francisduvivier
force-pushed
the
feature/26-upload-api-part-2
branch
from
bbd055c to
da8d725
Compare
francisduvivier
force-pushed
the
feature/26-upload-api-part-2
branch
from
beae63c to
a94a1e4
Compare
francisduvivier
requested review from
edwinm,
pitastrudl,
paulinevos and
zera1ul
francisduvivier
force-pushed
the
feature/26-upload-api-part-2
branch
from
a94a1e4 to
2a470fd
Compare
| ( | ||
| id text primary key, -- using text as recommended | ||
| email text unique, -- using text as recommended | ||
| admin boolean, |
There was a problem hiding this comment.
Still feel like we should use roles for this instead, i.e. a separate table user_roles with an FK to users.id and a 1 -> n relationship, so that users can have multiple roles
There was a problem hiding this comment.
Yeah haven't thought about this at all yet, the users table is actually just taken over from what we already had before this PR. (Except that I changed the user id to a string here in this PR, but then I changed it back to what we had in the next PR.)
There was a problem hiding this comment.
Let;s talk about it on Sunday to tie all this together with the middleware too
| password text not null, | ||
| remember_token text, | ||
| editor text, | ||
| public boolean, |
There was a problem hiding this comment.
What is the difference between public and show_projects?
There was a problem hiding this comment.
No Idea honestly.
Did not look into User data at all yet except for being able to relate them to a project.
Maybe @edwinm knows?
| email text unique, -- using text as recommended | ||
| admin boolean, | ||
| name text not null, | ||
| password text not null, |
There was a problem hiding this comment.
Also no idea. But actually good point. Gonna remove the user api for now so that this code for user insertion does not get used in production eventually accidentally.
| slug text not null primary key, | ||
| git text, | ||
| allow_team_fixes boolean, | ||
| constraint projects_user_id_fk foreign key (user_id) references users (id) on delete cascade -- if user is deleted, delete his projects |
There was a problem hiding this comment.
Yes true, if a user really get's deleted out of the DB as opposed to the deleted_at being set, then all the users' projects get deleted as well.
This way we can keep a more clean DB with stronger constraints about the validity of the data.
There was a problem hiding this comment.
No I meant their as in, singular they (which is gender neutral in English)
There was a problem hiding this comment.
Oh sorry completely missed that, let me update that.
Edit: added a commit to fix it: it 7f679a1
francisduvivier
force-pushed
the
feature/26-upload-api-part-1
branch
from
c1330de to
a6af53e
Compare
francisduvivier
force-pushed
the
feature/26-upload-api-part-2
branch
from
2a470fd to
c290e27
Compare
francisduvivier
changed the base branch from
feature/26-upload-api-part-1
to
main
…ot duplicating data We also make a layer between the API and the database in the style of DDD In order to write more readable queries, we also introduce the sql-template-tag library here
francisduvivier
force-pushed
the
feature/26-upload-api-part-2
branch
from
7f679a1 to
15fdef0
Compare
