Add dependencies needed for JWT authorization middleware #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File CoverageNo changed files found. |
edwinm
reviewed
Oct 25, 2024
There was a problem hiding this comment.
I already tried jsonwebtoken and found that the verify function of jsonwebtoken didn't work with our jwt's but when I used the jose package, it did work. I also saw some recommendations to use jose as a better replacement of jsonwebtoken. Maybe you can use that as well?
added 3 commits
November 13, 2024 14:38
Needed to sign and verify JWTs.
For signing JWTs in dev, will need to be set to something else in prod.
So people don't have to look inside the compose file or run `docker ps -a` to figure it out. (Also nice if they're not familiar with how port-forwarding works in docker)
|
@edwinm That seems odd, not sure why that library wouldn't work with our tokens? Should be the same across the board... anyway I've swapped it out for |
edwinm
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For verifying and decoding JWTs