-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add startDevForDockerCompose.sh and use it in docker compose for auto npm install #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francisduvivier
force-pushed
the
refactor/docker-start-script-for-no-node-modules
branch
2 times, most recently
from
October 7, 2024 19:33
6c6ba0b
to
add1078
Compare
francisduvivier
commented
Oct 7, 2024
@@ -14,7 +14,7 @@ | |||
"dev": "node --import tsx --watch src/index.ts", | |||
"backup": "docker exec -it badgehub-api-db-1 /usr/bin/pg_dump --username badgehub badgehub -f /var/backup/data-backup-`date +\"%Y-%m-%dT%H:%m\"`.sql", | |||
"test": "vitest", | |||
"prepare": "husky install" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
install command is apparently deprecated, just husky
does the job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct.
Not ready yet, first install is not working yet because of husky |
francisduvivier
force-pushed
the
refactor/docker-start-script-for-no-node-modules
branch
from
October 7, 2024 20:23
adfa5ea
to
1232a94
Compare
…n from the compose
francisduvivier
force-pushed
the
refactor/docker-start-script-for-no-node-modules
branch
from
October 7, 2024 20:24
1232a94
to
8936b1b
Compare
Coverage Report
File CoverageNo changed files found. |
edwinm
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
It's a little bit of overhead, but