-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new style resolver and connect - fixes build with boost 1.87.0 #1310
Conversation
heitbaum
commented
Dec 19, 2024
- closes future deprecated query from boost #1307
- additionally cleans up warnings
- call v1 boost headers fixing deprecated warning
from ../client/player/player.cpp:37: 8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/args.hpp>") 8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/async.hpp>") 8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/child.hpp>") 8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/exe.hpp>") | ^~~~~~~~~~~~~~~~~~~~~~~
Thanks, unfortunately it doesn't compile with boost < 1.87.0. |
Looks good. Works here. Only the warning remain.
|
Yes, this process stuff needs some special attention, using v1 for older boost versions and v2 for more recent versions, both versions have plenty of warnings, I think Snapcast needs some encapsulated process class, to not spread this boost process stuff on several places in the code base. According to the changelog boost process v1 will be removed in the next boost version:
Currently Snapcast requires boost version >= 1.74.0 and I will try to keep it compatible with older boost versions, because the boost version that is shipped in "stable" Linux distributions is usually a few versions behind. |
Likely we (LibreELEC) will go with 1.87.0 with LE13 in Q1 next year. So probably fine for the present. I’ll keep our dev tree up to current after LE13 is released - so we will see what 1.88+ brings — plus is that we have been able to identify these and close some already 👍 |