Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new style resolver and connect - fixes build with boost 1.87.0 #1310

Closed
wants to merge 2 commits into from

Conversation

heitbaum
Copy link
Contributor

    from ../client/player/player.cpp:37:
    8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/args.hpp>")
    8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/async.hpp>")
    8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/child.hpp>")
    8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/exe.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
@badaix
Copy link
Owner

badaix commented Dec 19, 2024

Thanks, unfortunately it doesn't compile with boost < 1.87.0.
I fixed it with less changes 6190041

@badaix badaix closed this Dec 19, 2024
@heitbaum
Copy link
Contributor Author

Thanks, unfortunately it doesn't compile with boost < 1.87.0. I fixed it with less changes 6190041

Looks good. Works here. Only the warning remain.

In file included from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/boost/config/header_deprecated.hpp:18,
                 from /var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/boost/process/args.hpp:7,
                 from ../client/player/player.cpp:37:
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/boost/process/args.hpp:8:1: note: '#pragma message: This header is deprecated. Use <boost/process/v1/args.hpp> instead.'
    8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/args.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/boost/process/async.hpp:8:1: note: '#pragma message: This header is deprecated. Use <boost/process/v1/async.hpp> instead.'
    8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/async.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/boost/process/child.hpp:8:1: note: '#pragma message: This header is deprecated. Use <boost/process/v1/child.hpp> instead.'
    8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/child.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~
/var/media/DATA/home-rudi/LibreELEC.tv/build.LibreELEC-Generic.x86_64-13.0-devel/toolchain/x86_64-libreelec-linux-gnu/sysroot/usr/include/boost/process/exe.hpp:8:1: note: '#pragma message: This header is deprecated. Use <boost/process/v1/exe.hpp> instead.'
    8 | BOOST_HEADER_DEPRECATED("<boost/process/v1/exe.hpp>")
      | ^~~~~~~~~~~~~~~~~~~~~~~

@badaix
Copy link
Owner

badaix commented Dec 20, 2024

Yes, this process stuff needs some special attention, using v1 for older boost versions and v2 for more recent versions, both versions have plenty of warnings, I think Snapcast needs some encapsulated process class, to not spread this boost process stuff on several places in the code base.

According to the changelog boost process v1 will be removed in the next boost version:

Process:
...
(v1) Added deprecation notice for 1.88.

Currently Snapcast requires boost version >= 1.74.0 and I will try to keep it compatible with older boost versions, because the boost version that is shipped in "stable" Linux distributions is usually a few versions behind.

@heitbaum
Copy link
Contributor Author

heitbaum commented Dec 20, 2024

Yes, this process stuff needs some special attention, using v1 for older boost versions and v2 for more recent versions, both versions have plenty of warnings, I think Snapcast needs some encapsulated process class, to not spread this boost process stuff on several places in the code base.

According to the changelog boost process v1 will be removed in the next boost version:

Process:
...
(v1) Added deprecation notice for 1.88.

Currently Snapcast requires boost version >= 1.74.0 and I will try to keep it compatible with older boost versions, because the boost version that is shipped in "stable" Linux distributions is usually a few versions behind.

Likely we (LibreELEC) will go with 1.87.0 with LE13 in Q1 next year. So probably fine for the present. I’ll keep our dev tree up to current after LE13 is released - so we will see what 1.88+ brings — plus is that we have been able to identify these and close some already 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

future deprecated query from boost
2 participants