-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for laravel 7 #126
Conversation
After this commit d20a3af, I have it installed successfully on my localhost. This PR is ready for review now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible that in upgrading this (for example) the call to new Process([])
we no longer support symfony process 2.0, 3.0, etc?
Are any of these old versions unnecessary?
@ShawnMcCool, not sure about that, I can check on Laravel 5.5. |
@ShawnMcCool I have tried this PR on Laravel 5.5 (on php 7.3) which uses Package installation Backup and restore command. |
Thank you for your diligence. I am merging this into master. Please load dev-master and verify that it is working as intended. Once it's verified I will tag a major release. |
Hi @ShawnMcCool, your welcome. I have tried the dev-master on my local for
From me, we can proceed to a new release tag, @ShawnMcCool. Thanks. |
Thank you. And I must say that you've been very professional to work with. I'm going to do a final review on docs etc and then tag a release. |
Hi so, I cut and slashed a bunch of old compatibility in the master branch, is there any way you can test 5.5 from master again? If not I understand. |
Hi @ShawnMcCool, sure. I have verified the
No issue found so far.
|
You are basically my hero right now. I have tagged 2.0 but you have done all the work. Thank you for your time and energy. |
Haha.. No problem @ShawnMcCool. It's nothing compared to your time building this package 😅 Thanks a lot to you. I am happy to help. |
In this PR, we are adding support for laravel 7. Related to #125.
How to test
Backup Manager now requires php ^7.3.
Create new laravel project
Add repositories on
composer.json
Install the package
See if the package successfully installed.