Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for laravel 7 #126

Merged
merged 2 commits into from
Apr 26, 2020

Conversation

nafiesl
Copy link
Contributor

@nafiesl nafiesl commented Apr 22, 2020

In this PR, we are adding support for laravel 7. Related to #125.

How to test

Backup Manager now requires php ^7.3.

$ php -v
PHP 7.4.3 (cli) (built: Feb 23 2020 07:24:02) ( NTS )

Create new laravel project

$ laravel new backup_manager_test

Add repositories on composer.json

    "repositories": [
        {
            "type": "vcs",
            "url":  "https://github.com/nafiesl/backup-manager-laravel"
        }
    ],

Install the package

$ composer require backup-manager/laravel dev-laravel_7_support

See if the package successfully installed.

@nafiesl
Copy link
Contributor Author

nafiesl commented Apr 22, 2020

This PR still has dependency issue, still working on it.

screen_20-04-23_001

@nafiesl
Copy link
Contributor Author

nafiesl commented Apr 22, 2020

The dependency issue is gone after I am using php 7.4.

Now i am facing a different error, still dig into it.

screen_20-04-23_002

@nafiesl
Copy link
Contributor Author

nafiesl commented Apr 22, 2020

After this commit d20a3af, I have it installed successfully on my localhost. This PR is ready for review now.

screen_20-04-23_003

@nafiesl nafiesl changed the title [WIP] Add support for laravel 7 Add support for laravel 7 Apr 22, 2020
@nafiesl nafiesl marked this pull request as ready for review April 22, 2020 23:18
@nafiesl nafiesl mentioned this pull request Apr 22, 2020
Copy link

@ShawnMcCool ShawnMcCool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that in upgrading this (for example) the call to new Process([]) we no longer support symfony process 2.0, 3.0, etc?

Are any of these old versions unnecessary?

@nafiesl
Copy link
Contributor Author

nafiesl commented Apr 25, 2020

@ShawnMcCool, not sure about that, I can check on Laravel 5.5.

@nafiesl
Copy link
Contributor Author

nafiesl commented Apr 26, 2020

@ShawnMcCool I have tried this PR on Laravel 5.5 (on php 7.3) which uses "symfony/process": "~3.3". And it works with no issue. I believe we good to go.

Package installation

screenshot_2020-04-26_004

Backup and restore command.

screenshot_2020-04-26_005
screenshot_2020-04-26_006

@ShawnMcCool
Copy link

Thank you for your diligence. I am merging this into master. Please load dev-master and verify that it is working as intended. Once it's verified I will tag a major release.

@ShawnMcCool ShawnMcCool merged commit f4f30b0 into backup-manager:master Apr 26, 2020
@nafiesl nafiesl deleted the laravel_7_support branch April 28, 2020 15:33
@nafiesl
Copy link
Contributor Author

nafiesl commented Apr 28, 2020

Hi @ShawnMcCool, your welcome.

I have tried the dev-master on my local for Laravel 7.9.1 and php 7.4:

  • Package installation complete
  • Backup feature success
  • Restore feature success

From me, we can proceed to a new release tag, @ShawnMcCool.

Thanks.

@ShawnMcCool
Copy link

Thank you. And I must say that you've been very professional to work with. I'm going to do a final review on docs etc and then tag a release.

@ShawnMcCool
Copy link

Hi so, I cut and slashed a bunch of old compatibility in the master branch, is there any way you can test 5.5 from master again? If not I understand.

@nafiesl
Copy link
Contributor Author

nafiesl commented Apr 30, 2020

Hi @ShawnMcCool, sure.

I have verified the dev-master on :

  • Laravel 5.5.49
  • php 7.3.17
  • MariaDB 10.3.

No issue found so far.

  • Package installation complete
  • Backup feature success
  • Restore feature success

@ShawnMcCool
Copy link

You are basically my hero right now. I have tagged 2.0 but you have done all the work. Thank you for your time and energy.

@nafiesl
Copy link
Contributor Author

nafiesl commented May 1, 2020

Haha.. No problem @ShawnMcCool. It's nothing compared to your time building this package 😅 Thanks a lot to you. I am happy to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants