Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate tensorflow 1.0 or higher #23

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

BGPark
Copy link

@BGPark BGPark commented May 5, 2017

Migrate some examples to the new API (1.0 or later). I have confirmed that my modifications work with TF versions 1.0 and 1.1.
However, the remaining uncommitted examples (araxiv and CNNs examples) still have problems with the new API.

It is not perfect, but I hope it helps others.

@johndpope
Copy link

johndpope commented Jun 22, 2017

@backstopmedia / @samjabrahams - please update this - or specify hard version with pip install requirements to older tensorflow.

@michael-GitHub-0
Copy link

Thanks, BGPark. I was able to adjust much of the code to suit the new API but your code is making my life much easier. Hopefully, the authors will update their code.

@danijar
Copy link
Collaborator

danijar commented Jul 14, 2017

@michael-GitHub-0 Did all examples work for you with this patch?

@michael-GitHub-0
Copy link

@danijar I am sorry, I haven't tried all of the code by BGPark. I only found this while working on chapter 5, and then I only pop over if I get stuck. I am new to GitHub.

@penchy-zju
Copy link

It would be really nice if all examples are fixed under tf 1.0 or higher.

@michael-GitHub-0
Copy link

The book started out very well, but something changed beginning with chapter 5. The writing was less explanatory (more typos, too) and more difficult to work with. I have made a few GitHub posts and sometimes the authors respond, and sometimes they don't. I have moved on to another book, myself.

@CosmosNing
Copy link

Thank you For your work !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants