Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): ignore backstage app, app-next (if exist) and backend packages when release plugins #1510

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jerolimov
Copy link
Contributor

@jerolimov jerolimov commented Oct 10, 2024

Hey, I just made a Pull Request!

This fixes #1508 by simple ignoring the "app", "app-next" (if exist) and "backend" when running yarn changeset version.

I tried this locally in the npm package, that contains a changeset and a backstage app.

Without this ignore list it touches this files:

	deleted:    .changeset/proud-brooms-clean.md
	modified:   packages/app/package.json
	modified:   plugins/npm/package.json
	new:        packages/app/CHANGELOG.md
	new:        plugins/npm/CHANGELOG.md

With this change it touches only:

	deleted:    .changeset/proud-brooms-clean.md
	modified:   plugins/npm/package.json
	new:        plugins/npm/CHANGELOG.md

I added this for all projects with packages.

code workspaces/*/packages/../.changeset/config.json

Fyi: I tried first yarn changeset version --ignore app --ignore backend, which works fine on projects with an backstage app, but is fails on these workspaces without.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@jerolimov jerolimov force-pushed the ignore-backstage-apps-and-backends branch from 29a2193 to 114c31a Compare October 10, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔧 Repository: Version job should skip the backstage apps (private npm packages)
1 participant