Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Jenkins-plugin-scaffolder #1481

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Added Jenkins-plugin-scaffolder #1481

wants to merge 16 commits into from
+280 −14

Conversation

Skiepp
Copy link
Contributor

@Skiepp Skiepp commented Oct 5, 2024 •
edited
Loading

Hey, I just made a Pull Request!

This plugin create a custom action jenkins:job:create which creates a new job on Jenkins during scaffolding process.
image

Described in issue / plugin request: #1478

✔️ Checklist

  • Documentation of the plugin can be found in the README provided
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message.

@Skiepp Skiepp requested a review from a team as a code owner October 5, 2024 09:34
@Skiepp Skiepp requested a review from vinzscam October 5, 2024 09:34
@backstage-goalie
Copy link
Contributor

backstage-goalie bot commented Oct 5, 2024 •
edited
Loading

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage-community/plugin-scaffolder-backend-module-jenkins workspaces/jenkins/plugins/jenkins-scaffolder none v0.1.0

@Skiepp
Fix correct handler as JsonObject
424026c 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
Run prettier
55efccd 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
Bump lockfile
32327a9 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
Dedupe lockfile
cc6bedf 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
Api Report
43f6eb5 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
Api Report
a13734f 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
Added PluginID
8c66cf6 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
pluginPackage
2507ded 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
yarn fix
8b76d1c 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
pluginPackage
fe96ab2 
Signed-off-by: Skiepp <[email protected]>
@Skiepp
Copy link
Contributor Author

Skiepp commented Oct 5, 2024

Tested after last successful commit:
image

vinzscam
vinzscam requested changes Oct 8, 2024
View reviewed changes
Copy link
Member

@vinzscam vinzscam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you, this is amazing 🤩

workspaces/jenkins/plugins/jenkins-scaffolder/package.json Outdated Show resolved Hide resolved
workspaces/jenkins/plugins/jenkins-scaffolder/README.md Outdated Show resolved Hide resolved
workspaces/jenkins/plugins/jenkins-scaffolder/README.md Outdated Show resolved Hide resolved
workspaces/jenkins/plugins/jenkins-scaffolder/README.md Outdated Show resolved Hide resolved
workspaces/jenkins/plugins/jenkins-scaffolder/src/action.ts Outdated Show resolved Hide resolved
@Skiepp
Copy link
Contributor Author

Skiepp commented Oct 8, 2024

Ciao @vinzscam,

thanks for the review! I pushed your suggestions, and of course tested again the plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinzscam vinzscam vinzscam requested changes

@backstage-service backstage-service Awaiting requested review from backstage-service backstage-service is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Skiepp @vinzscam