Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Repository: Version job should skip the backstage apps (private npm packages) #1508

Open
2 tasks done
jerolimov opened this issue Oct 10, 2024 · 1 comment · May be fixed by #1510
Open
2 tasks done

🔧 Repository: Version job should skip the backstage apps (private npm packages) #1508

jerolimov opened this issue Oct 10, 2024 · 1 comment · May be fixed by #1510
Labels
bug Something isn't working

Comments

@jerolimov
Copy link
Contributor

📜 Description

Some workspaces contains a backstage app that refers the included plugins. For each release process (Version ... PR) the app package.json was touched and the CHANGELOG.md of the app was extended. I guess that's not necessary.

Same happens for plugins with a backend plugin for the backend app.

I guess all this files can be removed:

ls -l workspaces/*/packages/{app,backend}/CHANGELOG.md

(33 CHANGELOG files)

👍 Expected behavior

Only the plugin code should be touched.

👎 Current Behavior

Also the packages app and backend are changed when a new release happen.

👟 Reproduction steps

Take a look in any Version PR for a plugin that contains a complete backstage app.

For example:

The app and backend package is marked as "private": true in their package.json. I guess this packages should be ignored.

📃 Provide the context for the Bug.

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

Yes I am willing to submit a PR!

@jerolimov jerolimov added the bug Something isn't working label Oct 10, 2024
@jerolimov
Copy link
Contributor Author

jerolimov commented Oct 10, 2024

I'm happy to take a look into the release/version process and I guess the starting point is this:

Right? If someone has any other hints, please let me know. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant