fixes #25 #48
Open
fixes #25 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertgarrigos thanks for submitting a PR. As usual, the procedure is to create an issue in the module's issue queue, and link it to the PR. I really can't test your PR because there is no issue in the Mimemal issue queue that describes the problem. I'm aware that there is an issue somewhere else that this intends to solve, but for the sake of reproduceability and documentation, Can you please create an issue in the Mimemail queue describing the problem and steps to reproduce? Thanks! |
|
OK, never mind, I see this is related to #25. I'll check it out. |
|
Sorry, @argiepiano I missed your message, don't understand why. Yes, it was actually linked to #25. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25.